lkml.org 
[lkml]   [2012]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 040/241] target: Don't return success from module_init() if setup fails
    Date
    3.5.7.2 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Roland Dreier <roland@purestorage.com>

    commit 0d0f9dfb31e0a6c92063e235417b42df185b3275 upstream.

    If the call to core_dev_release_virtual_lun0() fails, then nothing
    sets ret to anything other than 0, so even though everything is
    torn down and freed, target_core_init_configfs() will seem to succeed
    and the module will be loaded. Fix this by passing the return value
    on up the chain.

    Signed-off-by: Roland Dreier <roland@purestorage.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    drivers/target/target_core_configfs.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
    index 06aca11..ac0b69f 100644
    --- a/drivers/target/target_core_configfs.c
    +++ b/drivers/target/target_core_configfs.c
    @@ -3214,7 +3214,8 @@ static int __init target_core_init_configfs(void)
    if (ret < 0)
    goto out;

    - if (core_dev_setup_virtual_lun0() < 0)
    + ret = core_dev_setup_virtual_lun0();
    + if (ret < 0)
    goto out;

    return 0;
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-12-13 16:21    [W:2.337 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site