lkml.org 
[lkml]   [2012]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 200/241] drivers/net/ethernet/nxp/lpc_eth.c: Call mdiobus_unregister before mdiobus_free
    Date
    3.5.7.2 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Peter Senna Tschudin <peter.senna@gmail.com>

    commit 57c10b61c84bfed68b1b317d6f507a392724b9c4 upstream.

    Based on commit b27393aecf66199f5ddad37c302d3e0cfadbe6c0

    Calling mdiobus_free without calling mdiobus_unregister causes
    BUG_ON(). This patch fixes the issue.

    The semantic patch that found this issue(http://coccinelle.lip6.fr/):
    // <smpl>
    @@
    expression E;
    @@
    ... when != mdiobus_unregister(E);

    + mdiobus_unregister(E);
    mdiobus_free(E);
    // </smpl>

    Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
    Tested-by: Roland Stigge <stigge@antcom.de>
    Tested-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    drivers/net/ethernet/nxp/lpc_eth.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
    index 083d671..6793190 100644
    --- a/drivers/net/ethernet/nxp/lpc_eth.c
    +++ b/drivers/net/ethernet/nxp/lpc_eth.c
    @@ -1543,6 +1543,7 @@ static int lpc_eth_drv_remove(struct platform_device *pdev)
    pldat->dma_buff_base_p);
    free_irq(ndev->irq, ndev);
    iounmap(pldat->net_base);
    + mdiobus_unregister(pldat->mii_bus);
    mdiobus_free(pldat->mii_bus);
    clk_disable(pldat->clk);
    clk_put(pldat->clk);
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-12-13 16:01    [W:4.418 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site