lkml.org 
[lkml]   [2012]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 122/241] md: Avoid write invalid address if read_seqretry returned true.
    Date
    3.5.7.2 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: majianpeng <majianpeng@gmail.com>

    commit 35f9ac2dcec8f79d7059ce174fd7b7ee3290d620 upstream.

    If read_seqretry returned true and bbp was changed, it will write
    invalid address which can cause some serious problem.

    This bug was introduced by commit v3.0-rc7-130-g2699b67.
    So fix is suitable for 3.0.y thru 3.6.y.

    Reported-by: zhuwenfeng@kedacom.com
    Tested-by: zhuwenfeng@kedacom.com
    Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    drivers/md/md.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/md/md.c b/drivers/md/md.c
    index e977874..97edf9e 100644
    --- a/drivers/md/md.c
    +++ b/drivers/md/md.c
    @@ -1881,10 +1881,10 @@ retry:
    memset(bbp, 0xff, PAGE_SIZE);

    for (i = 0 ; i < bb->count ; i++) {
    - u64 internal_bb = *p++;
    + u64 internal_bb = p[i];
    u64 store_bb = ((BB_OFFSET(internal_bb) << 10)
    | BB_LEN(internal_bb));
    - *bbp++ = cpu_to_le64(store_bb);
    + bbp[i] = cpu_to_le64(store_bb);
    }
    bb->changed = 0;
    if (read_seqretry(&bb->lock, seq))
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-12-13 16:01    [W:4.775 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site