Messages in this thread | | | Date | Thu, 13 Dec 2012 07:30:42 -0700 | From | David Ahern <> | Subject | Re: [GIT PULL] perf changes for v3.8 |
| |
On 12/13/12 12:30 AM, Ingo Molnar wrote: > > * David Ahern <dsahern@gmail.com> wrote: > >>> But doing it this way was wrong. Switch that "exclude_guest" >>> attribute around, and admit that "H" was bogus, and that the >>> right thing to do was to add a "V" flag that sets the >>> "force_guest" flag instead. >> >> I understand this is annoying. [...] > > It's not annoying, it's outright broken - it's a regression that > we'll fix.
One of the problems is that existing binaries set the exclude_guest flag (https://lkml.org/lkml/2012/7/9/292).
So, requesting users to update their binaries if they want to use precise sampling is not acceptable. A 100% catastrophic failure of all running VMs is acceptable? All VMs will crash and there is no direct causal relationship.
David
| |