lkml.org 
[lkml]   [2012]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 127/241] x86, efi: Fix processor-specific memcpy() build error
    Date
    3.5.7.2 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Matt Fleming <matt.fleming@intel.com>

    commit 0f905a43ce955b638139bd84486194770a6a2c08 upstream.

    Building for Athlon/Duron/K7 results in the following build error,

    arch/x86/boot/compressed/eboot.o: In function `__constant_memcpy3d':
    eboot.c:(.text+0x385): undefined reference to `_mmx_memcpy'
    arch/x86/boot/compressed/eboot.o: In function `efi_main':
    eboot.c:(.text+0x1a22): undefined reference to `_mmx_memcpy'

    because the boot stub code doesn't link with the kernel proper, and
    therefore doesn't have access to the 3DNow version of memcpy. So,
    follow the example of misc.c and #undef memcpy so that we use the
    version provided by misc.c.

    See https://bugzilla.kernel.org/show_bug.cgi?id=50391

    Reported-by: Al Viro <viro@zeniv.linux.org.uk>
    Reported-by: Ryan Underwood <nemesis@icequake.net>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Signed-off-by: Matt Fleming <matt.fleming@intel.com>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    arch/x86/boot/compressed/eboot.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
    index 4e85f5f..f204178 100644
    --- a/arch/x86/boot/compressed/eboot.c
    +++ b/arch/x86/boot/compressed/eboot.c
    @@ -12,6 +12,8 @@
    #include <asm/setup.h>
    #include <asm/desc.h>

    +#undef memcpy /* Use memcpy from misc.c */
    +
    #include "eboot.h"

    static efi_system_table_t *sys_table;
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-12-13 15:21    [W:4.161 / U:0.628 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site