lkml.org 
[lkml]   [2012]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [TRIVIAL PATCH 12/26] s390: Convert print_symbol to %pSR
From
Date
On Wed, 2012-12-12 at 10:19 -0800, Joe Perches wrote:
> Use the new vsprintf extension to avoid any possible
> message interleaving.
[]
> diff --git a/arch/s390/kernel/traps.c b/arch/s390/kernel/traps.c
[]
> @@ -91,8 +91,9 @@ __show_trace(unsigned long sp, unsigned long low, unsigned long high)
> if (sp < low || sp > high - sizeof(*sf))
> return sp;
> sf = (struct stack_frame *) sp;
> - printk("([<%016lx>] ", sf->gprs[8] & PSW_ADDR_INSN);
> - print_symbol("%s)\n", sf->gprs[8] & PSW_ADDR_INSN);
> + printk("([<%016lx>] %pSR\n",

Sorry, this is defective, it needs a trailing ')' like:

+ printk("([<%016lx>] %pSR)\n",

> @@ -102,16 +103,18 @@ __show_trace(unsigned long sp, unsigned long low, unsigned long high)
> if (sp <= low || sp > high - sizeof(*sf))
> return sp;
> sf = (struct stack_frame *) sp;
> - printk(" [<%016lx>] ", sf->gprs[8] & PSW_ADDR_INSN);
> - print_symbol("%s\n", sf->gprs[8] & PSW_ADDR_INSN);
> + printk(" [<%016lx>] %pSR\n",

here too

I'll resubmit.



\
 
 \ /
  Last update: 2012-12-13 02:41    [W:0.379 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site