Messages in this thread | | | Date | Wed, 12 Dec 2012 23:45:50 +0100 | From | Borislav Petkov <> | Subject | Re: [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR |
| |
On Wed, Dec 12, 2012 at 02:23:59PM -0800, Joe Perches wrote: > On Wed, 2012-12-12 at 21:49 +0000, Luck, Tony wrote: > > > I think I'd go ahead and ACK this unless Tony has some comments. I'm not > > > happy about the two pr_emerg calls based on the conditional. > > > > As written the patch has the nice property of not making any changes to the > > console output (except to eliminate the possibility of interleaved output that > > the original code had). > > Well, it does eliminate a trailing space when m->cs != KERNEL_CS. > That probably won't hurt anything, but...
Yeah, that won't be an issue. So let's take it as is, as Tony suggests.
Acked-by: Borislav Petkov <bp@alien8.de>
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |