Messages in this thread | | | Subject | Re: [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR | From | Joe Perches <> | Date | Wed, 12 Dec 2012 14:23:59 -0800 |
| |
On Wed, 2012-12-12 at 21:49 +0000, Luck, Tony wrote: > > I think I'd go ahead and ACK this unless Tony has some comments. I'm not > > happy about the two pr_emerg calls based on the conditional. > > As written the patch has the nice property of not making any changes to the > console output (except to eliminate the possibility of interleaved output that > the original code had).
Well, it does eliminate a trailing space when m->cs != KERNEL_CS. That probably won't hurt anything, but...
| |