Messages in this thread | | | Date | Wed, 12 Dec 2012 13:01:52 -0800 | From | Andrew Morton <> | Subject | Re: [Xen-devel] [PATCH 2/2] xen-blkfront: implement safe version of llist_for_each_entry |
| |
On Mon, 10 Dec 2012 18:05:23 +0100 Roger Pau Monné <roger.pau@citrix.com> wrote:
> On 10/12/12 16:15, Konrad Rzeszutek Wilk wrote: > > On Mon, Dec 10, 2012 at 01:15:50PM +0100, Roger Pau Monné wrote: > >> On 07/12/12 21:20, Konrad Rzeszutek Wilk wrote: > >>> On Tue, Dec 04, 2012 at 03:21:53PM +0100, Roger Pau Monne wrote: > >>>> Implement a safe version of llist_for_each_entry, and use it in > >>>> blkif_free. Previously grants where freed while iterating the list, > >>>> which lead to dereferences when trying to fetch the next item. > >>> > >>> Looks like xen-blkfront is the only user of this llist_for_each_entry. > >>> > >>> Would it be more prudent to put the macro in the llist.h file? > >> > >> I'm not able to find out who is the maintainer of llist, should I just > >> CC it's author? > > > > Sure. I CC-ed akpm here to solicit his input as well. Either way I am > > OK wit this being in xen-blkfront but it just seems that it could > > be useful in the llist file since that is where the non-safe version > > resides. > > I'm going to resend this series with llist_for_each_entry_safe added to > llist.h in a separated patch. I wouldn't like to delay this series > because we cannot get llist_for_each_entry_safe added to llist.h, that's > why I've added it to blkfront in the first place.
Please include that llist.h patch within the xen merge. It's just a single hunk and won't cause any disruption. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |