Messages in this thread | | | Date | Wed, 12 Dec 2012 21:10:04 +0100 | From | Alexander Holler <> | Subject | Re: [PATCH 3/4] iio: merge hid-sensor-attributes.h into hid-sensor-hub.h |
| |
Am 12.12.2012 16:45, schrieb Pandruvada, Srinivas: > > One minor comment.
> +/* hid-sensor-attributes */ > + > +/* Common hid sensor iio structure */ > +struct hid_sensor_iio_common { > + struct hid_sensor_hub_device *hsdev; > + struct platform_device *pdev; > + unsigned usage_id; > + bool data_ready; > + struct hid_sensor_hub_attribute_info poll; > + struct hid_sensor_hub_attribute_info report_state; > + struct hid_sensor_hub_attribute_info power_state; > + struct hid_sensor_hub_attribute_info sensitivity; }; > > <Since it is not common to iio only, we should also remove iio in the structure name. > >
Ok, I play the patch-monkey and will send a patch 5/4.
Alexander
| |