Messages in this thread | | | Date | Wed, 12 Dec 2012 17:54:21 +0100 | Subject | Re: [PATCH] HID: i2c-hid: add mutex protecting open/close race | From | Benjamin Tissoires <> |
| |
On Wed, Dec 12, 2012 at 5:34 PM, Jean Delvare <khali@linux-fr.org> wrote: > Hi Benjamin, > > On Wed, 12 Dec 2012 17:12:16 +0100, Benjamin Tissoires wrote: >> We should not enter close function while someone else is in open. >> This mutex prevents this race. >> >> There is also no need to override the ret value with -EIO in case of >> a failure of i2c_hid_set_power. >> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> >> --- > > Looks good to me except that you forgot to include <linux/mutex.h> and > this could cause build failures on some architectures/configs. > > Once this is fixed, you can add: > > Reviewed-by: Jean Delvare <khali@linux-fr.org>
Thanks, I will resend it right now.
Cheers, Benjamin
> > -- > Jean Delvare
| |