Messages in this thread | | | Date | Wed, 12 Dec 2012 13:14:13 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/4] perf hists: Exchange order of comparing items when collapsing hists |
| |
Em Wed, Dec 12, 2012 at 04:56:32PM +0100, Jiri Olsa escreveu: > On Wed, Dec 12, 2012 at 12:29:26PM -0300, Arnaldo Carvalho de Melo wrote: > > Got inverted.
> > The order was arbitrary, and was arbitrarily reversed, are you guys sure this > > is the only side effect?
> right,
> currently (without namhyung's changes) there's initial 'name' sorting > broken by hists_link
> after the change, it gets sorted 'but' there are dummy entries added > which brake the sort again.. this is sorted out within the multi diff > patches
> so the bottom line is that currently the sorting is broken anyway, > and the fix is comming in upcomming patchset ;)
Ok, applied to my perf/core branch and pushed out.
> > Jiri, IIRC you mentioned that there would be some patch with an --order switch, > > would that allow sorting by the entry that had the biggest change, etc? > > by default it'll sorted by baseline and you can specify -o X to sort > by specified file
great.
- Arnaldo
| |