[lkml]   [2012]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/4] perf hists: Exchange order of comparing items when collapsing hists
Em Wed, Dec 12, 2012 at 04:56:32PM +0100, Jiri Olsa escreveu:
> On Wed, Dec 12, 2012 at 12:29:26PM -0300, Arnaldo Carvalho de Melo wrote:
> > Got inverted.

> > The order was arbitrary, and was arbitrarily reversed, are you guys sure this
> > is the only side effect?

> right,

> currently (without namhyung's changes) there's initial 'name' sorting
> broken by hists_link

> after the change, it gets sorted 'but' there are dummy entries added
> which brake the sort again.. this is sorted out within the multi diff
> patches

> so the bottom line is that currently the sorting is broken anyway,
> and the fix is comming in upcomming patchset ;)

Ok, applied to my perf/core branch and pushed out.

> > Jiri, IIRC you mentioned that there would be some patch with an --order switch,
> > would that allow sorting by the entry that had the biggest change, etc?
> by default it'll sorted by baseline and you can specify -o X to sort
> by specified file


- Arnaldo

 \ /
  Last update: 2012-12-12 17:21    [W:0.067 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site