lkml.org 
[lkml]   [2012]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] uio: do not expose inode to uio open/release hooks
On Wed, Dec 12, 2012 at 09:56:16AM +0100, Benedikt Spranger wrote:
> Am Wed, 12 Dec 2012 09:50:54 +0100
> schrieb "Hans J. Koch" <hjk@hansjkoch.de>:
>
> > On Tue, Dec 11, 2012 at 08:46:48PM -0800, Greg KH wrote:
> > > Yes, but what does that have to do with this in-kernel, internal api?
> >
> > Ah, OK. You're right, the commit message is confusing.
> >
> > Bene, it's enough to say we drop the inode parameter because nobody
> > ever needed it.
> I am fine with that.
>
> > I cannot see why this also helps with the other problem.
> It would help, because we can defer calling the release hook until the
> last mmap user is gone. In this case the inode pointer may not be valid
> anymore.

Which, again, is the same for any in-kernel driver with these types of
callbacks.

greg k-h


\
 
 \ /
  Last update: 2012-12-12 16:41    [W:0.086 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site