lkml.org 
[lkml]   [2012]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/hugetlb: create hugetlb cgroup file in hugetlb_init
On Wed 12-12-12 12:23:29, Michal Hocko wrote:
> On Wed 12-12-12 18:44:13, Xishi Qiu wrote:
[...]
> > Hi Michal,
> >
> > __initcall functions will be called in
> > start_kernel()
> > rest_init() // -> slab is already
> > kernel_init()
> > kernel_init_freeable()
> > do_basic_setup()
> > do_initcalls()
> >
> > and setup_hugepagesz() will be called in
> > start_kernel()
> > parse_early_param() // -> before mm_init() -> kmem_cache_init()
> >
> > Is this right?
>
> Yes this is right. I just noticed that kmem_cache_init_late is an __init
> function as well and didn't realize it is called directly. Sorry about
> the confusion.
> Anyway I still think it would be a better idea to move the call into the
> hugetlb_cgroup_create callback where it is more logical IMO but now that
> I'm looking at other controllers (blk and kmem.tcp) they all do this from
> init calls as well. So it doesn't make sense to have hugetlb behave
> differently.
>
> So
> Acked-by: Michal Hocko <mhocko@suse.cz>

Ohh, and this deserves to be backported to stable (since 3.6).
--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2012-12-12 14:01    [W:0.104 / U:1.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site