lkml.org 
[lkml]   [2012]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Line6linux-devel] [PATCH] staging: line6: pcm.c fix checkpatch issues
From
Ping ?

2012/11/30, Stefan Hajnoczi <stefanha@gmail.com>:
> Changes are fine.
>
> In the future, please split changes into individual patches. For example:
> Patch 1 - Rename 'rv' to 'ret'
> Patch 2 - Replace decprecated simple_strtoul() with kstrtoint() in
> pcm_set_impulse_period()
> Patch 3 - Realign comment in line6_init_pcm() switch statement
>
> Keeping patches focussed on doing just one thing makes it easier to
> revert, bisect, and review them.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@gmail.com>
>

Should I split patches as suggested by Stefan ?

Laurent.


\
 
 \ /
  Last update: 2012-12-12 14:01    [W:0.027 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site