Messages in this thread | | | From | Grant Likely <> | Date | Wed, 12 Dec 2012 11:45:59 +0000 | Subject | Re: [PATCH v2 0/3] gpio: twl4030: Correct status reporting for outputs |
| |
On Wed, Dec 12, 2012 at 11:12 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > Hi Grant, > > On 12/07/2012 09:09 AM, Linus Walleij wrote: >> On Thu, Dec 6, 2012 at 11:52 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: >> >>> As Grant commneted on the first version: >>> https://lkml.org/lkml/2012/12/5/53 >>> >>> Introduce bitfields to cache the directionand output status of the pins so we >>> can report them correctly. >>> To do this I did some cleanup within the driver to get rid of the global >>> variables and moved them under a private structure, changed the locking as well >>> to protect the bitfield operation. >>> As a last patch I added a note that the PWMA/B handling should not be in this >>> driver at all. >> >> This looks good to me: >> Acked-by: Linus Walleij <linus.walleij@linaro.org> >> >> Since Grant was requesting the changes I'll let him decide to merge. > > Would you have time to take a look at this set?
I will take a look at it this week, but I cannot pick it up for v3.8 unless it is a regression bug fix from v3.6. It will have to wait for v3.9 and it can be merged into linux-next after the v3.8 merge window closes.
g.
| |