lkml.org 
[lkml]   [2012]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] xen/blkback: prevent repeated backend_changed invocations
    On Wed, Dec 12, Jan Beulich wrote:

    > >>> On 11.12.12 at 21:50, Olaf Hering <olaf@aepfle.de> wrote:
    > > backend_changed might be called multiple times, which will leak
    > > be->mode. Make sure it will be called only once. Remove some unneeded
    > > checks. Also the be->mode string was leaked, release the memory on
    > > device shutdown.
    >
    > So did I miss some discussion here? I haven't seen any
    > confirmation of this function indeed being supposed to be called
    > just once.
    >
    > Also, as said previously, if indeed it is to be called just once,
    > removing the watch during/after the first invocation would seem
    > to be the more appropriate thing to do.

    Does the API allow this, that the called function can disable the watch?

    Olaf


    \
     
     \ /
      Last update: 2012-12-12 12:01    [W:2.681 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site