Messages in this thread | | | Date | Wed, 12 Dec 2012 09:42:39 +0000 | From | "Jan Beulich" <> | Subject | Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations |
| |
>>> On 11.12.12 at 21:50, Olaf Hering <olaf@aepfle.de> wrote: > backend_changed might be called multiple times, which will leak > be->mode. Make sure it will be called only once. Remove some unneeded > checks. Also the be->mode string was leaked, release the memory on > device shutdown.
So did I miss some discussion here? I haven't seen any confirmation of this function indeed being supposed to be called just once.
Also, as said previously, if indeed it is to be called just once, removing the watch during/after the first invocation would seem to be the more appropriate thing to do.
Jan
| |