lkml.org 
[lkml]   [2012]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] spi: fix return value check in hspi_probe().

Hi

> According to its documentation, clk_get() returns a "valid IS_ERR() condition
> containing errno", so we should call IS_ERR() rather than a NULL check.
>
> Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> ---
> drivers/spi/spi-sh-hspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
> index 32f7b55..60cfae5 100644
> --- a/drivers/spi/spi-sh-hspi.c
> +++ b/drivers/spi/spi-sh-hspi.c
> @@ -290,7 +290,7 @@ static int hspi_probe(struct platform_device *pdev)
> }
>
> clk = clk_get(NULL, "shyway_clk");
> - if (!clk) {
> + if (IS_ERR(clk)) {
> dev_err(&pdev->dev, "shyway_clk is required\n");
> ret = -EINVAL;
> goto error0;
> --
> 1.7.10.4
>
>
> ------------------------------------------------------------------------------
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> _______________________________________________
> spi-devel-general mailing list
> spi-devel-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/spi-devel-general


Best regards
---
Kuninori Morimoto


\
 
 \ /
  Last update: 2012-12-12 03:21    [W:0.138 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site