lkml.org 
[lkml]   [2012]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch v2 3/6] memcg: rework mem_cgroup_iter to use cgroup iterators
On Sun 09-12-12 11:39:50, Ying Han wrote:
> On Mon, Nov 26, 2012 at 10:47 AM, Michal Hocko <mhocko@suse.cz> wrote:
[...]
> > if (reclaim) {
> > - iter->position = id;
> > + struct mem_cgroup *curr = memcg;
> > +
> > + if (last_visited)
> > + css_put(&last_visited->css);
^^^^^^^^^^^
here
> > +
> > + if (css && !memcg)
> > + curr = mem_cgroup_from_css(css);
> > +
> > + /* make sure that the cached memcg is not removed */
> > + if (curr)
> > + css_get(&curr->css);
> > + iter->last_visited = curr;
>
> Here we take extra refcnt for last_visited, and assume it is under
> target reclaim which then calls mem_cgroup_iter_break() and we leaked
> a refcnt of the target memcg css.

I think you are not right here. The extra reference is kept for
iter->last_visited and it will be dropped the next time somebody sees
the same zone-priority iter. See above.

Or have I missed your question?

[...]
--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2012-12-11 17:21    [W:0.245 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site