Messages in this thread | | | Date | Tue, 11 Dec 2012 17:00:37 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree |
| |
Hello.
On 11-12-2012 14:58, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> The function at91_dt_node_to_map is ultimately called by the function > pinctrl_get, which is an exported function. Since it is possible that this > function is not called from within a probe function, for safety, the kfree > is converted to a devm_kfree, to both free the data and remove it from the > device in a failure situation.
> A newline is added in the call to devm_kfree to avoid exceeding the 80
devm_kzalloc() you mean?
> character limit.
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> --- > drivers/pinctrl/pinctrl-at91.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c > index c5e7571..0da8a5f 100644 > --- a/drivers/pinctrl/pinctrl-at91.c > +++ b/drivers/pinctrl/pinctrl-at91.c > @@ -255,7 +255,8 @@ static int at91_dt_node_to_map(struct pinctrl_dev *pctldev, > } > > map_num += grp->npins; > - new_map = devm_kzalloc(pctldev->dev, sizeof(*new_map) * map_num, GFP_KERNEL); > + new_map = devm_kzalloc(pctldev->dev, sizeof(*new_map) * map_num, > + GFP_KERNEL);
WBR, Sergei
| |