lkml.org 
[lkml]   [2012]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2] MCE: fix an error of mce_bad_pages statistics
    On Tue, Dec 11, 2012 at 10:25:00AM +0800, Xishi Qiu wrote:
    > On 2012/12/10 23:38, Andi Kleen wrote:
    >
    > >> It is another topic, I mean since the page is poisoned, so why not isolate it
    > >> from page buddy alocator in soft_offline_page() rather than in check_new_page().
    > >> I find soft_offline_page() only migrate the page and mark HWPoison, the poisoned
    > >> page is still managed by page buddy alocator.
    > >
    > > Doing it in check_new_page is the only way if the page is currently
    > > allocated by someone. Since that's not uncommon it's simplest to always
    > > do it this way.
    > >
    > > -Andi
    > >
    >
    > Hi Andi,
    >
    > The poisoned page is isolated in check_new_page, however the whole buddy block will
    > be dropped, it seems to be a waste of memory.
    >
    > Can we separate the poisoned page from the buddy block, then *only* drop the poisoned
    > page?

    That sounds like overkill. There are not so many free pages in a
    typical server system.

    Thanks,
    Fengguang


    \
     
     \ /
      Last update: 2012-12-11 04:01    [W:4.244 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site