lkml.org 
[lkml]   [2012]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: IRQ subsystem menu
Date
On Wed, 5 Dec 2012 21:16:20 -0500, Paul Thompson <set48035@gmail.com> wrote:
> Grant Likely <grant.likely@secretlab.ca>, on Thu 2012.11.29 said:
> > On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek <mmarek@suse.cz> wrote:
> > > (Adding lkml and Thomas as IRQ subsystem maintainer to CC)
> > >
> > > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote:
> > > > Hi;
> > > >
> > > > In menuconfig, General setup -> IRQ subsystem, there are two
> > > > possible menu-items. One depends partly on IRQ_DOMAIN, and the other
> > > > on MAY_HAVE_SPARSE_IRQ.
> > > >
> [...]
> > > >
> > > > Ideally, the "IRQ subsystem" menu would not even show up
> > > > if it would contain no menu-items, but I do not know enough to
> > > > formulate that constraint.
> >
> > First, move the 'menu "IRQ subsystem"' line does to right before the
> > IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you
> > can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right
> > below the menu item.
> >
> > You'll also need to move the IRQ_FORCED_THREADING line out from inside
> > the menu block.
> >
> > Try it out and let me know how it goes.
> >
> > g.
>
> Hi;
>
> The logic makes sense to me, and makes the menus appearance
> dependent on if either option setting can exist. So, on my system,
> the IRQ subsystem menu does not appear.
>
> Paul

Looks right to me. Please repost with a proper commit log and
"Signed-off-by" line and I'll apply this patch.
(See Documentation/SubmittingPatches)

g.



\
 
 \ /
  Last update: 2012-12-11 00:41    [W:0.057 / U:1.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site