lkml.org 
[lkml]   [2012]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] gpio: add Lynxpoint chipset gpio driver.
From
On Mon, Dec 10, 2012 at 3:06 PM, Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:

>>> +static void lp_irq_enable(struct irq_data *d)
>>> +{
>>> + struct lp_gpio *lg = irq_data_get_irq_chip_data(d);
>>> + u32 gpio = irqd_to_hwirq(d);
>>
>>
>> That variable is confusingly named. It's not a global gpio number,
>> it's a local offset, so please rename it "offset".
>
> sure, (is "pin" ok? "offset" is already used in may places)

pin will confuse things to the pinctrl subsystem ... offset is really nice.
But no super-big deal.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2012-12-10 23:01    [W:0.066 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site