Messages in this thread | | | From | Ohad Ben-Cohen <> | Date | Mon, 10 Dec 2012 20:07:41 +0200 | Subject | Re: [RFC 1/4] remoteproc: Bugfix assign device address to carveout (noiommu) |
| |
Hi Sjur,
On Thu, Dec 6, 2012 at 9:45 PM, Sjur Brændeland <sjurbren@gmail.com> wrote: > I just posted a RFC patch-set on this to linux-kernel@vger.kernel.org. > Review comments is welcomed :-)
Great, will take a look, thanks a lot!
> I have run into one issue with the dynamically allocated notifyids. When > allocating multiple virtio devices, only ids for the first virtio > device is allocated > when the remote device is started. This is fails for me, because I need to know > all of the kick-ids before starting the remote device. > > Do you have any preference on how to solve this, Ohad? > > One idea could be to call rproc->start from a work-queue and wait for completion > of firmware loading before actually starting. In this way we will not > trigger start-up > of the remote device before all virtio devices and their kick-ids are allocated.
Yes, it would work, but I'm not sure it would be very intuitive for others to understand why we spawn a new context upon powering on the processor.
Seems to me we may want instead to fix the problem directly by splitting rproc_handle_vdev() to two stages, where the second stage will only include the rproc_add_virtio_dev() part, and will be invoked after all vdev have been processed.
Will that work for you ?
Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |