Messages in this thread | | | Date | Mon, 10 Dec 2012 16:38:06 +0200 | From | Felipe Balbi <> | Subject | Re: [PATCH v4 23/23] mfd: omap-usb-host: Don't spam console on clk_set_parent failure |
| |
On Mon, Dec 10, 2012 at 01:31:22PM +0200, Roger Quadros wrote: > On 12/10/2012 01:24 PM, Rajendra Nayak wrote: > > On Monday 10 December 2012 03:50 PM, Roger Quadros wrote: > >> clk_set_parent is expected to fail on OMAP3 platforms. We don't > >> consider that as fatal so don't spam console. > > > > And what if it fails on a non-OMAP3 platform? > > The driver just prints a debug message and continues to work just as > before. The USB port will not work for the user in that case. He will > have to enable DEBUG flag to see the debug message. I see this behaviour > better than before where all OMAP3 users see the error message for no > reason.
I agree with Roger here.
-- balbi [unhandled content-type:application/pgp-signature] | |