lkml.org 
[lkml]   [2012]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1 v2] gpio: Provide the STMPE GPIO driver with its own IRQ Domain
On Mon, 10 Dec 2012, Linus Walleij wrote:

> On Mon, Dec 10, 2012 at 11:07 AM, Lee Jones <lee.jones@linaro.org> wrote:
>
> > Author: Lee Jones <lee.jones@linaro.org>
> > Date: Fri Nov 23 12:36:23 2012 +0000
> >
> > gpio: Provide the STMPE GPIO driver with its own IRQ Domain
> >
> > The STMPE GPIO driver can be used as an IRQ controller by some
>
> What is this funny citing and indentation business here... I stripped
> all the whitespace by hand, no big deal, just curious.
>
> Looks like you e.g. copy/pasted from a "git log" command log rather
> than from an actual patch.

Yeah, for v2 review, I usually use `git show` and copy from "Author:".

> > related devices. Here we provide it with its very own IRQ Domain
> > so that IRQs can be issued dynamically. This will stand the
> > driver in good stead when it is enabled for Device Tree, as this
> > it a prerequisite.
> >
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Applied.

Thanks dude.

> I apply this late because not using an irqdomain when we can is
> an abomination so I'm taking the risk.

NP.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-12-10 13:21    [W:0.086 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site