Messages in this thread | | | Subject | Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning | From | Simon Jeons <> | Date | Mon, 10 Dec 2012 05:17:15 -0600 |
| |
On Wed, 2012-12-05 at 16:47 -0500, Naoya Horiguchi wrote: > Memory error handling on hugepages can break a RSS counter, which emits > a message like "Bad rss-counter state mm:ffff88040abecac0 idx:1 val:-1". > This is because PageAnon returns true for hugepage (this behavior is
Could you explain why PageAnon returns true for hugepage?
> necessary for reverse mapping to work on hugetlbfs). > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > --- > mm/rmap.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git v3.7-rc8.orig/mm/rmap.c v3.7-rc8/mm/rmap.c > index 2ee1ef0..df54ef0 100644 > --- v3.7-rc8.orig/mm/rmap.c > +++ v3.7-rc8/mm/rmap.c > @@ -1235,7 +1235,9 @@ int try_to_unmap_one(struct page *page, struct vm_area_struct *vma, > update_hiwater_rss(mm); > > if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) { > - if (PageAnon(page)) > + if (PageHuge(page)) > + ; > + else if (PageAnon(page)) > dec_mm_counter(mm, MM_ANONPAGES); > else > dec_mm_counter(mm, MM_FILEPAGES);
| |