lkml.org 
[lkml]   [2012]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/6] scsi: bfa: remove useless calls to memset().
    Date
    These calls are followed by calls to memcpy() on the same memory area, so they
    can safely be removed.

    Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
    ---
    drivers/scsi/bfa/bfa_ioc.c | 1 -
    drivers/scsi/bfa/bfad_bsg.c | 1 -
    2 files changed, 2 deletions(-)

    diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c
    index 0116c10..dd2a2ef 100644
    --- a/drivers/scsi/bfa/bfa_ioc.c
    +++ b/drivers/scsi/bfa/bfa_ioc.c
    @@ -2517,7 +2517,6 @@ bfa_ioc_get_type(struct bfa_ioc_s *ioc)
    void
    bfa_ioc_get_adapter_serial_num(struct bfa_ioc_s *ioc, char *serial_num)
    {
    - memset((void *)serial_num, 0, BFA_ADAPTER_SERIAL_NUM_LEN);
    memcpy((void *)serial_num,
    (void *)ioc->attr->brcd_serialnum,
    BFA_ADAPTER_SERIAL_NUM_LEN);
    diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
    index 555e7db..9527fdb 100644
    --- a/drivers/scsi/bfa/bfad_bsg.c
    +++ b/drivers/scsi/bfa/bfad_bsg.c
    @@ -3197,7 +3197,6 @@ bfad_fcxp_map_sg(struct bfad_s *bfad, void *payload_kbuf,
    goto out_free_mem;

    /* copy the linear bsg buffer to buf_info */
    - memset(buf_info->virt, 0, buf_info->size);
    memcpy(buf_info->virt, payload_kbuf, buf_info->size);

    /*
    --
    1.7.10.4


    \
     
     \ /
      Last update: 2012-12-02 04:01    [W:3.243 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site