Messages in this thread |  | | Date | Sat, 1 Dec 2012 22:44:38 +0100 | From | Ingo Molnar <> | Subject | Re: [RFC GIT PULL] scheduler fix for autogroups |
| |
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Sat, Dec 1, 2012 at 3:16 AM, Ingo Molnar <mingo@kernel.org> wrote: > > > > Please [RFC] pull the latest sched-urgent-for-linus git tree > > from: > > No. That patch is braindead. I wouldn't pull it even if it > wasn't this late. > > Why the hell leave a read-only 'sched_autogroup_enabled' proc > file? > > What the f*ck is the point? It looks like the flag still > exists (we test it), but now there's no point to it, since you > can't change it. > > What am I missing?
You are not missing anything. That flag is my fault not Mike's: I booted the initial version of that patch but was unsure whether autogroups was enabled - it's a pretty transparent feature. So I figured that having that flag (but readonly) would give us this information definitely.
So I suggested to Mike to keep that flag so that user-space is informed that autogroups is enabled. It seemed like a cute usability twist at that time, and there's existing precedent for it in /proc, but now I'm not so sure anymore...
Should we use some other file for that - or no file at all and just emit a bootup printk for kernel hackers with a short attention span?
Thanks,
Ingo
|  |