Messages in this thread | | | Date | Sat, 1 Dec 2012 21:39:29 +0300 | From | Dan Carpenter <> | Subject | Re: [RFC PATCH] staging, android, ashmem: invalidate pin/unpin ioctl for private map |
| |
On Sat, Dec 01, 2012 at 02:45:57AM +0900, Joonsoo Kim wrote: > @@ -614,21 +616,35 @@ static int ashmem_pin_unpin(struct ashmem_area *asma, unsigned long cmd, > pgstart = pin.offset / PAGE_SIZE; > pgend = pgstart + (pin.len / PAGE_SIZE) - 1; > > - mutex_lock(&ashmem_mutex); > + if (asma->shared_mapping) { > + mutex_lock(&ashmem_mutex);
Wouldn't we need to hold the mutex while we check the ->shared_mapping?
regards, dan carpenter
| |