Messages in this thread | | | From | "Philip, Avinash" <> | Subject | RE: [PATCH v2 08/10] pwm: pwm-tiehrpwm: Adding TBCLK gating support. | Date | Fri, 9 Nov 2012 10:59:30 +0000 |
| |
On Fri, Nov 09, 2012 at 13:41:04, Thierry Reding wrote: > On Thu, Nov 08, 2012 at 01:23:15PM +0530, Philip, Avinash wrote: ... > > + /* Some platforms require explicit tbclk gating */ > > + if (of_property_read_bool(pdev->dev.of_node, "tbclkgating")) { > > Is it really necessary to have an extra boolean property for this? > Couldn't this just be handled by not defining a clock for the tbclk > consumer in board setup/DT
If no clk node defined, driver can still continue expecting this platform the requirement is not there. So I will check for tbclk with devm_clk_get() and continue by removing Boolean property.
> > > + pc->tbclk = clk_get(&pdev->dev, "tbclk"); > > You should be using devm_clk_get() or add a matching clk_put() in > .remove().
Ok
Thanks Avinash
> > Thierry >
| |