lkml.org 
[lkml]   [2012]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 8/7] pppoatm: fix missing wakeup in pppoatm_send()
    From
    From: David Woodhouse <dwmw2@infradead.org>
    Date: Wed, 07 Nov 2012 12:52:14 +0000

    > Now that we can return zero from pppoatm_send() for reasons *other* than
    > the queue being full, that means we can't depend on a subsequent call to
    > pppoatm_pop() waking the queue, and we might leave it stalled
    > indefinitely.
    >
    > Fix this by immediately scheduling the wakeup tasklet. As documented
    > already elsewhere, the PPP channel's ->downl lock protects against the
    > wakeup happening too soon and effectively being missed.
    >
    > Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
    > ----
    > Untested.
    > With this sorted, Acked-By: David Woodhouse <David.Woodhouse@intel.com<
    > to the other seven. Thanks.

    I don't know what to do with this patch because I don't have any
    context whatsoever.

    So I'm tossing it, please resubmit it when it's meant to be
    applied, and with some context.


    \
     
     \ /
      Last update: 2012-11-09 23:21    [W:4.906 / U:0.828 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site