lkml.org 
[lkml]   [2012]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 3/3] tools/hv: Fix permissions of created directory and files
Date


> -----Original Message-----
> From: Tomas Hozza [mailto:thozza@redhat.com]
> Sent: Friday, November 09, 2012 9:01 AM
> To: olaf@aepfle.de; KY Srinivasan; gregkh@linuxfoundation.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; apw@canonical.com;
> jasowang@redhat.com; ben@decadent.org.uk
> Cc: Tomas Hozza
> Subject: [PATCH 3/3] tools/hv: Fix permissions of created directory and files
>
> From: Ben Hutchings <ben@decadent.org.uk>
>
> It's silly to create directories without execute permission, or to
> give permissions to 'other' but not the group-owner.
>
> Write the permissions in octal and 'ls -l' format since these are much
> easier to read than the named macros.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Tomas Hozza <thozza@redhat.com>

Acked-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
> tools/hv/hv_kvp_daemon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index 573b9aa..9609858 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -236,7 +236,7 @@ static int kvp_file_init(void)
> int alloc_unit = sizeof(struct kvp_record) * ENTRIES_PER_BLOCK;
>
> if (access("/var/lib/hyperv", F_OK)) {
> - if (mkdir("/var/lib/hyperv", S_IRUSR | S_IWUSR | S_IROTH)) {
> + if (mkdir("/var/lib/hyperv", 0755 /* rwxr-xr-x */)) {
> syslog(LOG_ERR, " Failed to create /var/lib/hyperv");
> exit(EXIT_FAILURE);
> }
> @@ -247,7 +247,7 @@ static int kvp_file_init(void)
> records_read = 0;
> num_blocks = 1;
> sprintf(fname, "/var/lib/hyperv/.kvp_pool_%d", i);
> - fd = open(fname, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR |
> S_IROTH);
> + fd = open(fname, O_RDWR | O_CREAT, 0644 /* rw-r--r-- */);
>
> if (fd == -1)
> return 1;
> --
> 1.7.11.7
>
>




\
 
 \ /
  Last update: 2012-11-09 17:21    [W:0.141 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site