lkml.org 
[lkml]   [2012]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/4] Staging: winbond: wb35rx_s: Fixed coding style issue
From
On Thu, Nov 8, 2012 at 12:59 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> It's better to use more descriptive subjects on the patches.
>
> This one could probably have been broken into smaller patches
> [patch 4/x] Staging: winbond: wb35rx_s: fix white space
> [patch 5/x] Staging: winbond: wb35rx_s: fix comments
> [patch 6/x] Staging: winbond: wb35rx_s: allow header to be included twice
>
> It's small enough that I don't have strong feelings about it, but
> in general that's how you should do it.
>

Thanks Dan for your comment. I'll keep this in mind during my future work.

Regards,
Adil

> regards,
> dan carpenter
>


\
 
 \ /
  Last update: 2012-11-08 11:21    [W:2.177 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site