lkml.org 
[lkml]   [2012]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8/9] cgroup_freezer: add ->post_create() and ->pre_destroy() and track online state
    (2012/11/03 17:38), Tejun Heo wrote:
    > A cgroup is online and visible to iteration between ->post_create()
    > and ->pre_destroy(). This patch introduces CGROUP_FREEZER_ONLINE and
    > toggles it from the newly added freezer_post_create() and
    > freezer_pre_destroy() while holding freezer->lock such that a
    > cgroup_freezer can be reilably distinguished to be online. This will
    > be used by full hierarchy support.
    >
    > ONLINE test is added to freezer_apply_state() but it currently doesn't
    > make any difference as freezer_write() can only be called for an
    > online cgroup.
    >
    > Adjusting system_freezing_cnt on destruction is moved from
    > freezer_destroy() to the new freezer_pre_destroy() for consistency.
    >
    > This patch doesn't introduce any noticeable behavior change.
    >
    > Signed-off-by: Tejun Heo <tj@kernel.org>
    > ---
    > kernel/cgroup_freezer.c | 42 ++++++++++++++++++++++++++++++++++++++++--
    > 1 file changed, 40 insertions(+), 2 deletions(-)
    >
    > diff --git a/kernel/cgroup_freezer.c b/kernel/cgroup_freezer.c
    > index b8ad93c..4f12d31 100644
    > --- a/kernel/cgroup_freezer.c
    > +++ b/kernel/cgroup_freezer.c
    > @@ -23,6 +23,7 @@
    > #include <linux/seq_file.h>
    >
    > enum freezer_state_flags {
    > + CGROUP_FREEZER_ONLINE = (1 << 0), /* freezer is fully online */

    Could you explain what 'online' means here again, rather than changelog ?
    BTW, 'online' is a shared concept, between post_create() and pre_destroy(), among
    developpers ? Is it new ?

    Anyway, the patch itself is simple.

    Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>




    \
     
     \ /
      Last update: 2012-11-08 06:44    [W:4.132 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site