Messages in this thread | | | Date | Thu, 8 Nov 2012 09:59:02 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 1/2] gpio: tegra: create irq mapping in gpio_to_irq |
| |
On Wednesday 07 November 2012 10:38 PM, Stephen Warren wrote: > On 11/07/2012 08:01 AM, Laxman Dewangan wrote: >> The gpio interrupts get mapped linearly and hence the mapping >> of irq need to be created by irq_create_mapping(). >> >> The function gpio_to_irq() returns the irq by irq_find_mapping() >> and so returns 0 as there is no mapping created. Fix the function >> to create mapping when gpio_to_irq() get called. > I'm not convinced this should be needed. tegra_gpio_probe() contains:
Oh, yes, I did not observe this code in my review. So this change is not resolving any issue.
I think we should move the mapping to gpio_to_irq() rather than doing this in probe.
| |