Messages in this thread | | | Date | Thu, 08 Nov 2012 10:32:44 +0800 | From | Qing Xu <> | Subject | Re: [PATCH v4 5/7] mfd: max8925: support dt for regulator |
| |
On 11/07/2012 10:20 PM, Mark Brown wrote: > On Wed, Nov 07, 2012 at 06:09:53PM +0800, Qing Xu wrote: >> From: Qing Xu <qingx@marvell.com> >> >> Signed-off-by: Qing Xu <qingx@marvell.com> > Applied, thanks. > >> +max8925 regulator device register is still handled by mfd_add_devices, not by >> +of_xxx, so, it is not necessary to add compatible name. Also, those reg >> +offset and id info is stored in mfd_cell(see max8925-core.c), as a result >> +there is not private properties in dts. >> +node's name should match with the definition in max8925_regulator_matches >> +(see max8925-regulator.c) > Please submit a followup which removes all the Linux-specific references > and just enumerates the supported regulators. Please do also use a > subject line appropriate for the subsystem - this is for the regulator > driver so it should be regulator: updated in another patch, please help me review it, thanks.
| |