Messages in this thread | | | Date | Wed, 07 Nov 2012 18:59:51 -0500 (EST) | Subject | Re: [PATCH 1/1] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES | From | David Miller <> |
| |
From: Lee Jones <lee.jones@linaro.org> Date: Wed, 7 Nov 2012 10:55:03 +0100
> It doesn't make much sense to enable ISDN services if you don't > intend to connect to a network. Therefore insisting that ISDN > depends on NETDEVICES seems logical. We can then remove any > guards mentioning NETDEVICES inside all subordinate drivers. > > This also has the nice side-effect of fixing the warning below > when ISDN_I4L && !CONFIG_NETDEVICES at compile time. > > This patch fixes: > drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: > drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ [-Wunused-variable] > > Cc: Karsten Keil <isdn@linux-pingi.de> > Cc: netdev@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thanks.
| |