Messages in this thread | | | Date | Tue, 6 Nov 2012 23:13:54 -0800 | Subject | Re: [RESEND PATCH V3] binfmt_elf.c: use get_random_int() to fix entropy depleting | From | Kees Cook <> |
| |
On Tue, Nov 6, 2012 at 11:02 PM, Jeff Liu <jeff.liu@oracle.com> wrote: > On 11/07/2012 02:21 PM, Kees Cook wrote: >> I still want to hear at least from Ted about this changes -- we would >> be potentially increasing the predictability of these bytes... > > We would not increasing that if this routine would be used for AT_RANDOM > only(and if the array keeping aligned to 4 bytes). > Otherwise, it would be, so let's waiting for further feedbacks.
get_random_int() comes from a different pool than get_random_bytes(), IIUC. I'd like to hear some convincing reasoning as to why this change doesn't compromise predictability. :)
-Kees
-- Kees Cook Chrome OS Security
| |