Messages in this thread | | | Date | Wed, 07 Nov 2012 10:11:41 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH 2/2] gpio: tegra: fix suspend/resume apis |
| |
On 11/07/2012 08:01 AM, Laxman Dewangan wrote: > Following are changes done to fix the suspend/resume > functionality of tegra gpio driver: > - Protect suspend/resume callbacks with CONFIG_PM_SLEEP > because CONFIG_PM doesn't actually enable any of the PM callbacks, it > only allows to enable CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME. > This means if CONFIG_PM is used to protect system sleep callbacks > then it may end up unreferenced if only runtime PM is enabled. > > - Fix the suspend/resume APIs declaration as per callback prototype.
Seems plausible, so this patch, Acked-by: Stephen Warren <swarren@nvidia.com>
I wonder why the suspend/resume functions weren't actually hooked up anywhere before. Oh well.
Just one very minor nit below:
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> +#ifdef CONFIG_PM_SLEEP > +static int tegra_gpio_resume(struct device *dev)
There are two spaces after "int" there.
| |