Messages in this thread | | | Date | Wed, 07 Nov 2012 10:08:09 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH 1/2] gpio: tegra: create irq mapping in gpio_to_irq |
| |
On 11/07/2012 08:01 AM, Laxman Dewangan wrote: > The gpio interrupts get mapped linearly and hence the mapping > of irq need to be created by irq_create_mapping(). > > The function gpio_to_irq() returns the irq by irq_find_mapping() > and so returns 0 as there is no mapping created. Fix the function > to create mapping when gpio_to_irq() get called.
I'm not convinced this should be needed. tegra_gpio_probe() contains:
> for (gpio = 0; gpio < tegra_gpio_chip.ngpio; gpio++) { > int irq = irq_create_mapping(irq_domain, gpio);
which should create the mapping for every IRQ.
(although I do think the gpiochip_add() should be moved to the very end of probe(), I doubt that impacts this issue much)
| |