lkml.org 
[lkml]   [2012]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 9/9] cgroup_freezer: implement proper hierarchy support
Hello, Michal.

On Wed, Nov 07, 2012 at 12:00:57PM +0100, Michal Hocko wrote:
> > + * Update all its descendants in pre-order traversal. Each
> > + * descendant will try to inherit its parent's FREEZING state as
> > + * CGROUP_FREEZING_PARENT.
> > + */
> > + rcu_read_lock();
> > + cgroup_for_each_descendant_pre(pos, freezer->css.cgroup) {
> > + struct freezer *pos_f = cgroup_freezer(pos);
> > + struct freezer *parent = parent_freezer(freezer);
>
> This doesn't seem right. Why are we interested in freezer->parent here
> at all? We should either care about freezer->state & CGROUP_FREEZING or
> parent = parent_freezer(pos_f), right?

Yeap, that should have been parent_freezer(pos_f). Argh...

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-11-07 18:21    [W:0.166 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site