Messages in this thread | | | Date | Wed, 07 Nov 2012 20:27:17 +0800 | From | Alex Shi <> | Subject | Re: [RFC PATCH 1/3] sched: add sched_policy and it's sysfs interface |
| |
>> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c >> index 6345294..5f6a573 100644 >> --- a/drivers/base/cpu.c >> +++ b/drivers/base/cpu.c >> @@ -330,4 +330,6 @@ void __init cpu_dev_init(void) >> panic("Failed to register CPU subsystem"); >> >> cpu_dev_register_generic(); >> + >> + create_sysfs_sched_policy_group(cpu_subsys.dev_root); > > Are you sure you didn't just race with userspace, creating the sysfs > files after the device was created and announced to userspace?
Sorry for don't fully get you. Is the sysfs announced to userspace just in 'mount -t sysfs sysfs /sys'?
The old powersaving interface: sched_smt_power_savings also created here. and cpu_dev_init was called early before do_initcalls which cpuidle/cpufreq sysfs were initialized.
Do you mean this line need to init as core_initcall?
Thanks for comments! :) > > If so, you need to fix this :) > > thanks, > > greg k-h >
-- Thanks Alex
| |