Messages in this thread | | | Subject | Re: [PATCH V2 3/3] checkpatch: Emit an warning when floating point values are used | From | Joe Perches <> | Date | Wed, 07 Nov 2012 03:09:35 -0800 |
| |
On Tue, 2012-11-06 at 15:36 -0800, Andrew Morton wrote: > On Thu, 1 Nov 2012 00:12:18 -0700 > Joe Perches <joe@perches.com> wrote: > > Linux kernel doesn't like floating point, say so. [] > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -2332,6 +2332,13 @@ sub process { > > "do not add new typedefs\n" . $herecurr); > > } > > > > +# check for floating point constants > > + > > + if ($line =~ /\b$Float\b/) { > > + WARN("KERNEL_FLOAT", > > + "Floating point is not supported in linux kernel source\n" . $herecurr); > > + } > > + > > # * goes on variable not on type > > # (char*[ const]) > > while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) { > > The earlier review comments were not addressed.
You didn't read my response in the thread then. I "addressed" it by saying that the problem exists without solution.
> In particular, I don't see a problem with people doing > > int foo = 1.1 * 2.2;
Neither do I but I know of no way to determine that any calc is a constant.
| |