Messages in this thread | | | Date | Tue, 6 Nov 2012 09:57:40 +0100 | Subject | Re: [PATCH v2] pinctrl: samsung: Add ifdef CONFIG_OF_GPIO guard for gc->of_node | From | Linus Walleij <> |
| |
On Tue, Nov 6, 2012 at 6:03 AM, Thomas Abraham <thomas.abraham@linaro.org> wrote: > On 5 November 2012 21:14, Axel Lin <axel.lin@ingics.com> wrote:
>> +#if defined(CONFIG_OF_GPIO) >> gc->of_node = bank->of_node; >> +#endif > > The samsung pinctrl driver supports only device tree enabled > platforms. So instead of adding the above #if, would it not be better > to add 'select OF_GPIO' for Samsung pinctrl driver in > drivers/pinctrl/Kconfig. ?
Or edit the Samsung driver to depend on OF_GPIO, this is probably better.
Yours, Linus Walleij
| |