lkml.org 
[lkml]   [2012]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] pinctrl: samsung: Add ifdef CONFIG_OF_GPIO guard for gc->of_node
From
On Tue, Nov 6, 2012 at 6:03 AM, Thomas Abraham
<thomas.abraham@linaro.org> wrote:
> On 5 November 2012 21:14, Axel Lin <axel.lin@ingics.com> wrote:

>> +#if defined(CONFIG_OF_GPIO)
>> gc->of_node = bank->of_node;
>> +#endif
>
> The samsung pinctrl driver supports only device tree enabled
> platforms. So instead of adding the above #if, would it not be better
> to add 'select OF_GPIO' for Samsung pinctrl driver in
> drivers/pinctrl/Kconfig. ?

Or edit the Samsung driver to depend on OF_GPIO, this is probably
better.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2012-11-06 10:44    [W:0.057 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site