Messages in this thread | | | Date | Mon, 5 Nov 2012 17:57:03 -0800 | Subject | Re: [PATCH 103/104] mm: remove depends on CONFIG_EXPERIMENTAL | From | Kees Cook <> |
| |
On Mon, Nov 5, 2012 at 5:54 PM, Kees Cook <keescook@chromium.org> wrote: > On Mon, Nov 5, 2012 at 5:22 PM, David Rientjes <rientjes@google.com> wrote: >> On Mon, 5 Nov 2012, Kees Cook wrote: >> >>> diff --git a/mm/Kconfig b/mm/Kconfig >>> index a3f8ddd..679945e 100644 >>> --- a/mm/Kconfig >>> +++ b/mm/Kconfig >>> @@ -1,6 +1,5 @@ >>> config SELECT_MEMORY_MODEL >>> def_bool y >>> - depends on EXPERIMENTAL || ARCH_SELECT_MEMORY_MODEL >>> >>> choice >>> prompt "Memory model" >> >> I thought you agreed to only drop EXPERIMENTAL here in >> http://marc.info/?l=linux-kernel&m=135103415901094 and leave >> ARCH_SELECT_MEMORY_MODEL, which you've orphaned with the above, for phase >> two of your effort? > > Ah! Yes, thanks. I'll restore that.
Wait, no. This is an "OR". ARCH_SELECT_MEMORY_MODEL has no affect on SELECT_MEMORY_MODEL if EXPERIMENTAL is always considered on. My proposal was to deal with ARCH_SELECT_MEMORY_MODEL separately. Did I misunderstand something?
-Kees
-- Kees Cook Chrome OS Security
| |