Messages in this thread | | | From | Alexander Stein <> | Subject | Re: [PATCH 1/2] HDA: Fix digital microphone on CS420x | Date | Mon, 05 Nov 2012 09:59:21 +0100 |
| |
Hello,
On Monday 05 November 2012 07:22:24, Daniel J Blueman wrote: > On 4 November 2012 16:16, Takashi Iwai <tiwai@suse.de> wrote: > > Thanks, this looks more comprehensive. DIG1 and DIG2 seem to have > > been set wrongly in the original code, based on the Cirrus's example > > code. Is the right-only recording problem fixed by this patch? > > > > It is fixed. In the mbp101 init verbs, setting the vendor widget ADC > configuration bit 12 to copy the ADC2 right channel to the left (0x1004 to > nid 0x11 coef 2) is superfluous here, so presumably for the analogue mic > in. I'll get time later to check all this. > > The second coefficient index initialisation (0x000f to nid 0x11 coef 4) is > now redundant, as we enable the mic bits later correctly now. I'll send an > updated patch which drops this. > > Alexander, could you check this doesn't break your machine?
I replaced my 2nd patch "hda: Cirrus: Fix wrong ADC config" with Daniel's patch "HDA: Fix digital microphone on CS420x" and I still get stereo in both ADC channels I'm using. So, no breakage, but I can't comment on the digital mic patch, because I'm not using it.
Best regards, Alexander -- Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH August-Bebel-Str. 29 D-07973 Greiz
Tel: +49-3661-6279-0, Fax: +49-3661-6279-99 eMail: Alexander.Stein@systec-electronic.com Internet: http://www.systec-electronic.com
Managing Director: Dipl.-Phys. Siegmar Schmidt Commercial registry: Amtsgericht Jena, HRB 205563
| |