Messages in this thread Patch in this message | | | Date | Mon, 05 Nov 2012 16:28:05 -0600 | From | Mark Langsdorf <> | Subject | Re: [PATCH 1/6 v2] arm: use devicetree to get smp_twd clock |
| |
On 11/04/2012 04:08 AM, Russell King - ARM Linux wrote: > On Fri, Nov 02, 2012 at 01:51:44PM -0500, Mark Langsdorf wrote: >> -static struct clk *twd_get_clock(void) >> +static struct clk *twd_get_clock(struct device_node *np) >> { >> - struct clk *clk; >> + struct clk *clk = NULL; >> int err; >> >> - clk = clk_get_sys("smp_twd", NULL); >> + if (np) >> + clk = of_clk_get(np, 0); >> + if (!clk) > > What does a NULL return from of_clk_get() mean? Where is this defined?
Well, it's a valid path if (np) is NULL. I'll add an IS_ERR(clk) and resubmit.
>> @@ -349,6 +348,10 @@ int __init twd_local_timer_register(struct twd_local_timer *tlt) >> if (!twd_base) >> return -ENOMEM; >> >> + twd_clk = twd_get_clock(NULL); >> + >> + twd_clk = twd_get_clock(NULL); >> + > > Why twice?
No good reason. I'll resubmit with it cleaned up. Thanks for the review.
--Mark Langsdorf Calxeda, Inc.
| |