Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] drivers/misc/kgdbts.c: remove eprintk | Date | Mon, 5 Nov 2012 20:01:49 +0000 |
| |
On Monday 05 November 2012, Julia Lawall wrote: > OK, I could try proposing that, and if someone doesn't think it is the > right thing to do, they can ignore the patch. > > Concretely, KERN_WARNING should be added in the printk called from WARN, > and all KERN information should be removed from the calls?
I think that would be the right solution, yes. Unfortunately, I don't know how to easily do this since we are already passing down a format string into vprintk here. Maybe just add the KERN_WARNING at the point where __WARN_printf gets called.
Arnd
| |